Skip to content

feat(modeldetailsbuildingstats): added two properties for ART for commerce #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

feat(modeldetailsbuildingstats): added two properties for ART for commerce #930

merged 1 commit into from
Apr 9, 2025

Conversation

lprovost-coveo
Copy link
Contributor

@lprovost-coveo lprovost-coveo commented Apr 7, 2025 •
edited
Loading

Adding addToCart and addPurchase

Same thing as the other properties. No documentation,
Sister PR : https://github.com/coveo-platform/ml-config-service/pull/2536

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@lprovost-coveo lprovost-coveo requested review from a team as code owners April 7, 2025 15:24
@lprovost-coveo lprovost-coveo added this pull request to the merge queue Apr 9, 2025
Merged via the queue into master with commit a2ef544 Apr 9, 2025
13 checks passed
@lprovost-coveo lprovost-coveo deleted the feat/MLX-2031-add-art-commerce-properties branch April 9, 2025 17:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025

🎉 This PR is included in version 58.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GermainBergeron GermainBergeron GermainBergeron approved these changes

@paulgerold paulgerold paulgerold approved these changes

@gdostie gdostie Awaiting requested review from gdostie gdostie is a code owner automatically assigned from coveo/frontend-foundation

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lprovost-coveo @GermainBergeron @paulgerold