Skip to content

blip tester: pass full history to proposeChanges #7656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

torcolvin
Copy link
Collaborator

@torcolvin torcolvin commented Jul 31, 2025

There are not yet tests which require this code, that will come shortly.

  • Fix jira ticket number about proposeChanges
  • Pass full hlv history to proposeChanges
  • Accept 409 pushing a rev, which will happen if proposeChanges was OK and then a conflict appears wheen

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@Copilot Copilot AI review requested due to automatic review settings July 31, 2025 13:38
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the BLIP tester client to pass full HLV (Hybrid Logical Vector) history to proposeChanges requests and handles 409 conflicts that may occur after successful proposeChanges calls.

Key changes:

  • Pass complete HLV history string to proposeChanges when HLV is enabled
  • Accept 409 conflict responses during rev push as non-errors
  • Fix JIRA ticket reference from CBG-4466 to CBG-4461

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
rest/utilities_testing_blip_client.go Updates proposeChanges to include full HLV history and handles 409 conflicts in sendRev
db/crud.go Corrects JIRA ticket reference in comment from CBG-4466 to CBG-4461

@torcolvin
Copy link
Collaborator Author

Superseded by #7657

@torcolvin torcolvin closed this Aug 1, 2025
@torcolvin torcolvin deleted the blip-fixes branch August 1, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants