Skip to content

DOC-13103-updated the description for bootstrap.server #7617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2025

Conversation

iamfortune
Copy link
Contributor

@iamfortune iamfortune commented Jul 4, 2025

DOC-13103

Describe your PR here...

  • I updated the description for bootstrap.server, made it more in-depth like the legacy.

I didn't find a style guide for updating these, let me know if there's one.

Screenshot 2025-07-04 at 2 50 23 pm

@iamfortune iamfortune requested review from torcolvin, bbrks and Copilot July 4, 2025 14:01
Copy link

github-actions bot commented Jul 4, 2025

Redocly previews

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR expands the bootstrap.server description to provide in-depth guidance on connection string formats, examples, port requirements, alternate addresses, network parameters, and reconnection behavior.

  • Replaced brief server description with a detailed multiline block
  • Added IPv4/IPv6 examples, port guidance, and network parameter options
  • Explained startup fallback and reconnection logic
Comments suppressed due to low confidence (2)

docs/api/components/schemas.yaml:2072

  • [nitpick] Inline comments using // within the backtick-enclosed examples can be confusing; consider moving the explanatory text outside the code snippet or using parentheses so the example remains a valid code literal.
            - `http://[2001:db8::8811]:8091` // single node IPv6 - http scheme with default server port

docs/api/components/schemas.yaml:2076

  • [nitpick] The port requirements section applies only to couchbase:// and couchbases:// schemes—consider clarifying that http:// connections default to the management port (8091) instead of the bucket port.
            **Port Requirements**

@torcolvin torcolvin self-assigned this Jul 7, 2025
Copy link
Collaborator

@torcolvin torcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not preview the suggested changes, but I notice some markdown oddities. To preview this document locally:

npx @redocly/cli@latest preview-docs admin

and expand response on http://127.0.0.1:8080/#tag/Server/operation/get__config

@torcolvin torcolvin assigned iamfortune and unassigned torcolvin Jul 8, 2025
@iamfortune iamfortune assigned torcolvin and unassigned iamfortune Jul 8, 2025
@iamfortune
Copy link
Contributor Author

I have updated these, let me know if you've got any more feedback or if I missed anything.

@torcolvin torcolvin enabled auto-merge (squash) July 11, 2025 01:48
@torcolvin torcolvin merged commit 750e942 into main Jul 11, 2025
30 checks passed
@torcolvin torcolvin deleted the DOC-13103-document-kv-limitations branch July 11, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants