Skip to content

fix: handled ibc-v2 universal error ack #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2025
Merged

fix: handled ibc-v2 universal error ack #260

merged 2 commits into from
Apr 7, 2025

Conversation

srdtrk
Copy link
Member

@srdtrk srdtrk commented Apr 7, 2025

closes: #259

gjermundgaraba
gjermundgaraba approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also tested locally that this work as expected.

@gjermundgaraba gjermundgaraba merged commit 0a4f81e into main Apr 7, 2025
4 of 7 checks passed
@gjermundgaraba gjermundgaraba deleted the serdar/259-err-ack branch April 7, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjermundgaraba gjermundgaraba gjermundgaraba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rate limiting middleware doesn't handle IBC v2 error acknowledgements
2 participants
@srdtrk @gjermundgaraba