Skip to content

perf!: concurrent merge with optional debugging #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 18, 2023
Merged

perf!: concurrent merge with optional debugging #61

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
47904a0
refactor: enable debug by default for MergedFileDescriptors
mark-rushakoff Apr 13, 2023
e72cf89
test: add benchmarks for MergedFileDescriptors
mark-rushakoff Apr 14, 2023
0d6d88b
feat: add concurrent proto registry merge functions
mark-rushakoff Apr 14, 2023
0bfdfd3
chore: don't use bytes.Clone from go1.20
mark-rushakoff Apr 15, 2023
e6d1320
test: fix representative benchmark to include global FD set
mark-rushakoff Apr 17, 2023
7b6c214
test: move representative benchmarks to proper test package
mark-rushakoff Apr 17, 2023
4169e5b
test: fix test to use merge with validation
mark-rushakoff Apr 17, 2023
56b34dc
chore: clean up godoc for concurrent merge and helpers
mark-rushakoff Apr 17, 2023
6aa4b1e
refactor: remove sequential registry merge implementation
mark-rushakoff Apr 17, 2023
9d031c6
chore: update changelog
mark-rushakoff Apr 17, 2023
cf9db71
chore: use correct function name in comments
mark-rushakoff Apr 18, 2023
66dc75b
chore: update changelog for 1.4.8 release today
mark-rushakoff Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

## Unreleased

### Breaking changes

- [#61](https://github.com/cosmos/gogoproto/pull/60) Use all available cores when merging registries.
Existing calls to `proto.MergedRegistry()` do not need to change.
The signature of `proto.MergedFileDescriptors` has changed to accept explicit arguments for the "global files" and "app files".
Calls to `proto.MergedFileDescriptors()` should change to `proto.MergedGlobalFileDescriptors()` or `proto.MergedGlobalFileDescriptorsWithValidation()`.

### Improvements

- [#59](https://github.com/cosmos/gogoproto/pull/59) Reuse buffers and gzip readers to reduce memory allocations during MergedFileDescriptors.
Expand Down
Loading