Add test to verify query response compression (#6849) #6877
+90
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddarth Gundu <[email protected]>
yeya24
reviewed
Jul 12, 2025
| require.NoError(t, err) | ||
| require.Equal(t, 200, res.StatusCode) | ||
|
|
||
| storeGateway := e2ecortex.NewStoreGateway("store-gateway", e2ecortex.RingStoreConsul, consul.NetworkHTTPEndpoint(), flags, "") |
There was a problem hiding this comment.
We don't need store gateway in this test so let's remove it.
|
|
||
| require.Equal(t, http.StatusOK, resp.StatusCode) | ||
| require.Empty(t, resp.Header.Get("Content-Encoding")) | ||
| }) |
There was a problem hiding this comment.
The current tests are good. But I'd like to see we have test cases covering queries against query frontend as well. Not just querier
There was a problem hiding this comment.
Oh alright, I'l add a new endpoint with query frontend and update the tests. Thanks a lot for the review !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds an integration test which checks the
Content-Encodingheader. This ensures that query response compression works correctlyWhich issue(s) this PR fixes:
Fixes #6849
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]