Skip to content

Querier: Support configuring optimizers and XFunctions #6873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Querier: Support configuring optimizers and XFunctions #6873

wants to merge 1 commit into from

Conversation

harry671003
Copy link
Contributor

@harry671003 harry671003 commented Jul 10, 2025 •
edited
Loading

What this PR does:

  • Adds new config for enabling XFunctions - xincrease(), xrate(), xdelta(), configuring optimizers etc for Thanos engine.
  • I took the liberty to refactor the engine config into it's own struct. Assuming we can make breaking changes here since Thanos engine is marked as experimental.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@harry671003 harry671003 changed the title Refactor engine config Querier: Refactor engine config Jul 10, 2025
@harry671003 harry671003 force-pushed the refactor_engine_config branch 4 times, most recently from edea965 to c160724 Compare July 10, 2025 21:33
@harry671003 harry671003 changed the title Querier: Refactor engine config Querier: Support configuring optimizers and XFunctions Jul 10, 2025
@harry671003 harry671003 marked this pull request as ready for review July 10, 2025 21:33
@harry671003 harry671003 force-pushed the refactor_engine_config branch 2 times, most recently from 099bdbf to 9052bee Compare July 10, 2025 22:08
@harry671003 harry671003 force-pushed the refactor_engine_config branch from 9052bee to 895dd48 Compare July 11, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component/querier size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@harry671003