Skip to content

Allow 2h block conversion if it has no compact mark #6865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SungJin1212
Copy link
Member

Allow the parquet converter to convert 2h blocks if the block has a no-compact.mark.json file.

Which issue(s) this PR fixes:
Fixes #6831

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added the storage/blocks Blocks storage engine label Jul 7, 2025
@SungJin1212 SungJin1212 requested a review from yeya24 July 7, 2025 02:49
@SungJin1212 SungJin1212 force-pushed the Allow-2h-nocompactmark-block-conversion branch from b3c1f38 to 528d1af Compare July 7, 2025 03:06
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I think it looks good. Just some nits.

We should probably also introduce bucket cache for no compact marker file to reduce number of calls to object store

@yeya24 yeya24 requested a review from alanprot July 7, 2025 05:32
@SungJin1212 SungJin1212 force-pushed the Allow-2h-nocompactmark-block-conversion branch 2 times, most recently from ce12528 to 369dbf3 Compare July 7, 2025 11:23
@SungJin1212 SungJin1212 requested a review from yeya24 July 9, 2025 00:50
@SungJin1212 SungJin1212 force-pushed the Allow-2h-nocompactmark-block-conversion branch from 369dbf3 to 54d9d99 Compare July 9, 2025 03:26
@SungJin1212 SungJin1212 force-pushed the Allow-2h-nocompactmark-block-conversion branch from 54d9d99 to 7bb8c24 Compare July 9, 2025 05:39
@SungJin1212
Copy link
Member Author

@alanprot
Could you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L storage/blocks Blocks storage engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parquet Converter should convert 2h block with no compact marker
2 participants