retrieve peakSamples and processedSamples query stats from results_cache #6591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlan-z
force-pushed
the
query-stats-from-results-cache
branch
from
02a62ed to
b4200d5
Compare
yeya24
reviewed
Feb 16, 2025
pkg/frontend/transport/handler.go
Outdated
| @@ -409,6 +409,7 @@ func (f *Handler) reportQueryStats(r *http.Request, source, userID string, query | |||
| "split_queries", splitQueries, | |||
| "status_code", statusCode, | |||
| "response_size", contentLength, | |||
| "samples_processed", numScannedSamples, | |||
There was a problem hiding this comment.
Why we don't call it samples_scanned? queryScannedSamples metric is named cortex_query_samples_scanned_total so we should be consistent here
|
Seems there are files unrelated to this PR. Can you remove them? |
erlan-z
force-pushed
the
query-stats-from-results-cache
branch
from
b4200d5 to
70bf569
Compare
…che as well Signed-off-by: Erlan Zholdubai uulu <[email protected]>
erlan-z
force-pushed
the
query-stats-from-results-cache
branch
from
70bf569 to
508b9b8
Compare
yeya24
reviewed
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
with this PR, peakSamples and processedSamples was added to query stats. They work when queries are directly queried from datasource, and doesn't apply for results_cache.
this PR will populate those fields for query stats for responses from results cache
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]