Add tls config to consul #6374
Merged
Add tls config to consul #6374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SungJin1212
force-pushed
the
Add-consul-tls
branch
from
260cefd to
3f6d656
Compare
alanprot
approved these changes
Nov 26, 2024
|
thanks |
SungJin1212
force-pushed
the
Add-consul-tls
branch
from
3f6d656 to
33c19b7
Compare
CharlieTLe
reviewed
Nov 27, 2024
|
|
||
| # Override the expected name on the server certificate. | ||
| # CLI flag: -<prefix>.consul.tls-server-name | ||
| [tls_server_name: <string> | default = ""] |
There was a problem hiding this comment.
I don't think this flag is used. Could we update the implementation so that it is used?
There was a problem hiding this comment.
Thanks for the catch :D
| }) | ||
| } | ||
|
|
||
| if cfg.EnableTLS { |
There was a problem hiding this comment.
Could we add a test for this?
There was a problem hiding this comment.
I have updated the pr. Thanks!
SungJin1212
force-pushed
the
Add-consul-tls
branch
from
33c19b7 to
36f54f3
Compare
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Add-consul-tls
branch
from
36f54f3 to
9db957d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a tls config to consul like other kv stores (etcd, memberlist).
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]