Fix: PostingCache promise should fetch data only once #6314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Follow up of #6296
Under concurrency, we are fetching the postings multiples times for the same key.
The reason for that is we load the previous promise from the cache but the promise does not have the ts set yet and so, we assume is expired:
See:
cortex/pkg/storage/tsdb/expanded_postings_cache.go
Lines 320 to 332 in 2e5488a
This PR is simplifying the implementation and waiting the loaded promise to finish before checking if is expired.
First commit of the PR has only the test showing the problem.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]