Reduce default multilevel index cache max async concurrency to 3 #6265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Change-index-cache-concurrency
branch
from
86a621f to
ff49d31
Compare
SungJin1212
changed the title
friedrichg
approved these changes
Oct 14, 2024
yeya24
reviewed
Oct 14, 2024
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| ## master / unreleased | |||
|
|
|||
| * [CHANGE] Change default value of `-blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency` from `50` to `3` #6265 | |||
There was a problem hiding this comment.
Oops. I think the changelog is wrong. You changed -blocks-storage.bucket-store.index-cache.multilevel.max-async-concurrency not -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency.
Let's create a new PR to change all async concurrency to 3, including Redis cache
There was a problem hiding this comment.
Thank you for catching my mistake. I will be making another PR.
3 tasks
yeya24
changed the title
yeya24
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
-blocks-storage.bucket-store.index-cache.memcached.max-async-concurrencydefault value 50 to 3 as mentioned in #6249Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]