Support application credential auth for Openstack swift #6255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SungJin1212
force-pushed
the
Add-application-credential-to-swift
branch
2 times, most recently
from
60975f9 to
decf611
Compare
yeya24
approved these changes
Oct 27, 2024
There was a problem hiding this comment.
I am not too familiar with Swift. Is this PR basically exposing thanos-io/objstore#32? Then LGTM.
Let's fix changelog conflict
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Add-application-credential-to-swift
branch
from
decf611 to
4645f3a
Compare
|
@yeya24 For example, the OpenStack admin would want to secretly manage |
CharlieTLe
pushed a commit
to CharlieTLe/cortex
that referenced
this pull request
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only way to auth is to use
username/passwordwhen users use Swift backend. But there is a case where users don't know their OpenStack account but application credentials issued by others (administrators of Openstack account, they don't want to expose Openstack account'susername/password). To address this concern, support an application credential auth for OpenStack swift backend so that users can auth in various ways (username/passwordorapplication credential).Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]