Deprecate 'querier.ingester-metadata-streaming' flag #6147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
alanprot
force-pushed
the
deprecate/querier.ingester-metadata-streaming
branch
from
259831a to
020050e
Compare
yeya24
reviewed
Aug 9, 2024
| @@ -108,7 +108,7 @@ func (cfg *Config) RegisterFlags(f *flag.FlagSet) { | |||
| cfg.StoreGatewayClient.RegisterFlagsWithPrefix("querier.store-gateway-client", f) | |||
| f.IntVar(&cfg.MaxConcurrent, "querier.max-concurrent", 20, "The maximum number of concurrent queries.") | |||
| f.DurationVar(&cfg.Timeout, "querier.timeout", 2*time.Minute, "The timeout for a query.") | |||
| f.BoolVar(&cfg.IngesterMetadataStreaming, "querier.ingester-metadata-streaming", false, "Use streaming RPCs for metadata APIs from ingester.") | |||
| f.BoolVar(&cfg.IngesterMetadataStreaming, "querier.ingester-metadata-streaming", true, "Deprecated (This feature will be always on after v1.18): Use streaming RPCs for metadata APIs from ingester.") | |||
There was a problem hiding this comment.
Should we use flagext.DeprecatedFlag instead?
There was a problem hiding this comment.
I wanna keep the flag functional for 1 release.
DeprecatedFlag is used when we removed the flag entirely.
Do u wanna remove the flag at once -> i did not do as, until now, the default was false. =/
yeya24
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Deprecate and enable by default
querier.ingester-metadata-streamingflag and mark to be removed after v1.18.This flag is around and stable for more than 2 years and there is no reason to be disabled.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]