Add cortex_query_samples_total metric #6142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SungJin1212
force-pushed
the
add-query-samples-metric
branch
from
2454692 to
e3ee864
Compare
SungJin1212
force-pushed
the
add-query-samples-metric
branch
from
e3ee864 to
625dfb0
Compare
SungJin1212
changed the title
SungJin1212
force-pushed
the
add-query-samples-metric
branch
3 times, most recently
from
b10a60f to
7b247fc
Compare
yeya24
previously approved these changes
Aug 8, 2024
pkg/frontend/transport/handler.go
Outdated
| @@ -116,6 +117,11 @@ func NewHandler(cfg HandlerConfig, roundTripper http.RoundTripper, log log.Logge | |||
| Help: "Number of series fetched to execute a query.", | |||
| }, []string{"user"}) | |||
|
|
|||
| h.querySamples = promauto.With(reg).NewCounterVec(prometheus.CounterOpts{ | |||
| Name: "cortex_query_samples_total", | |||
| Help: "Number of samples to execute a query.", | |||
There was a problem hiding this comment.
Fixed it. Thanks for the review. @yeya24
Signed-off-by: kade.lee <[email protected]>
SungJin1212
force-pushed
the
add-query-samples-metric
branch
from
7b247fc to
c13a766
Compare
yeya24
approved these changes
Aug 8, 2024
|
I like that! :) |
alanprot
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add a new per tenant metric called cortex_query_samples_total which contains the number of fetched samples for each query requests. It provides an accurate count of fetched samples for each tenants.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],x,[BUGFIX]