Using ingester id instead of address on the distributor metrics. #6078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alanprot <[email protected]>
alanprot
force-pushed
the
use-ingester-if-dist-metric
branch
from
92a3374 to
8cbbd8e
Compare
Signed-off-by: alanprot <[email protected]>
alanprot
force-pushed
the
use-ingester-if-dist-metric
branch
from
8cbbd8e to
49d3d3f
Compare
Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Change the metrics
cortex_distributor_ingester_appends_total,cortex_distributor_ingester_append_failures_total,cortex_distributor_ingester_queries_total, andcortex_distributor_ingester_query_failures_totalto use the ingester ID instead of the IP as the label value.Previously, we used the IP as the label value, which made it challenging to correlate IP addresses with specific ingesters and resulted in unclear dashboard graphs.
With this change, the ingester ID will be used instead of the IP.
Before:
After:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]