Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in code and docs #5784

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Fix typos in code and docs #5784

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2577e7a
Fix typos in code and docs
CharlieTLe Feb 22, 2024
10ba468
Run make docs to update generated docs
CharlieTLe Feb 23, 2024
4dfbdd6
Apply suggestions from @friedrichg
CharlieTLe Feb 26, 2024
e842e08
Revert changes to vendor file
CharlieTLe Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/configuration/config-file-reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4750,7 +4750,7 @@ grpc_tls_config:
# CLI flag: -server.grpc-tls-ca-path
[client_ca_file: <string> | default = ""]

# Register the instrumentation handlers (/metrics etc).
# Register the intrumentation handlers (/metrics etc).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be coming from https://github.com/weaveworks/common/blob/master/server/server.go#L154 which is outside of this repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is true and any weaveworks repo is probably already archived.
We can fix this in another PR.

# CLI flag: -server.register-instrumentation
[register_instrumentation: <boolean> | default = true]

Expand Down