Skip to content

Update proposal for timeseries partitioning in compactor #4882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 24, 2022
Merged

Update proposal for timeseries partitioning in compactor #4882

merged 7 commits into from
Oct 24, 2022

Conversation

alexqyle
Copy link
Contributor

@alexqyle alexqyle commented Sep 28, 2022 •
edited by alvinlin123
Loading

What this PR does:
Added compaction and clean up workflow to partitioning compactor proposal (#4843)

Which issue(s) this PR fixes:
Design to fix #4705

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@alvinlin123
Copy link
Contributor

@alexqyle opps, lint failed. It's usually due to trailing space in the markdwon file :-)

alvinlin123
alvinlin123 reviewed Sep 28, 2022
View reviewed changes
Copy link
Contributor

@alvinlin123 alvinlin123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you so much for adding these details.

But, I think the Compaction Workflow section contains too much implementation details, which is not suitable in a proposal.

Compaction Partitioning Examples section is good to keep.

@alexqyle
Updated wording
1aab1cc 
Signed-off-by: Alex Le <[email protected]>
@alexqyle
Updated cleaner logic to be more straightforward and keep checking co…
032b7f8 
…mpletion logic in compactor

Signed-off-by: Alex Le <[email protected]>
@alanprot alanprot merged commit 6a48d3c into cortexproject:master Oct 24, 2022
@alexqyle alexqyle deleted the partition-grouper-cleaner-proposal branch July 17, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 left review comments

@alvinlin123 alvinlin123 alvinlin123 approved these changes

@alanprot alanprot alanprot approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to compact due to maximum index size 64 GiB
4 participants
@alexqyle @alvinlin123 @alanprot @yeya24