Remove support for chunks storage entirely: Take 2 #4812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Andrew Bloomgarden <[email protected]>
Signed-off-by: Andrew Bloomgarden <[email protected]>
Signed-off-by: Andrew Bloomgarden <[email protected]>
Signed-off-by: Andrew Bloomgarden <[email protected]>
Signed-off-by: Andrew Bloomgarden <[email protected]>
Signed-off-by: Andrew Bloomgarden <[email protected]>
Signed-off-by: Andrew Bloomgarden <[email protected]>
Signed-off-by: Andrew Bloomgarden <[email protected]>
Signed-off-by: Andrew Bloomgarden <[email protected]>
Signed-off-by: Andrew Bloomgarden <[email protected]>
Signed-off-by: Andrew Bloomgarden <[email protected]>
Signed-off-by: Andrew Bloomgarden <[email protected]>
Signed-off-by: Andrew Bloomgarden <[email protected]>
Signed-off-by: Andrew Bloomgarden <[email protected]>
Signed-off-by: Andrew Bloomgarden <[email protected]>
Signed-off-by: Andrew Bloomgarden <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
alanprot
force-pushed
the
no_chunks
branch
2 times, most recently
from
5d9ac0b to
ed8222f
Compare
alanprot
force-pushed
the
no_chunks
branch
15 times, most recently
from
0c0fdfc to
778bb5a
Compare
Signed-off-by: Alan Protasio <[email protected]>
This was referenced Aug 11, 2022
3 tasks
1 task
3 tasks
CharlieTLe
added a commit
that referenced
this pull request
Dec 24, 2024
Flag `ingester.max-samples-per-query` was removed in #4812 as part of the chunk storage removal.
CharlieTLe
added a commit
to CharlieTLe/cortex
that referenced
this pull request
Dec 24, 2024
Flag `ingester.max-samples-per-query` was removed in cortexproject#4812 as part of the chunk storage removal. Signed-off-by: Charlie Le <[email protected]>
CharlieTLe
added a commit
that referenced
this pull request
Dec 24, 2024
Flag `ingester.max-samples-per-query` was removed in #4812 as part of the chunk storage removal. Signed-off-by: Charlie Le <[email protected]>
friedrichg
pushed a commit
that referenced
this pull request
Dec 30, 2024
* Update arguments.md Removed obsolete `-promql.lookback-delta` option (deprecated since Cortex 1.2, replaced with `-querier.lookback-delta`). #3144 Signed-off-by: Charlie Le <[email protected]> Signed-off-by: Charlie Le <[email protected]> * Rename `-querier.split-queries-by-day` to `-querier.split-queries-by-... ...interval` Query-frontend: removed `-querier.split-queries-by-day` (deprecated in Cortex 0.4.0). Please use `-querier.split-queries-by-interval` instead. #3813 Signed-off-by: Charlie Le <[email protected]> * Fix typo and add description for `max_samples_per_query` Flag `ingester.max-samples-per-query` was removed in #4812 as part of the chunk storage removal. Signed-off-by: Charlie Le <[email protected]> * Remove 'Storage' section from arguments documentation Removed in 73567bc#diff-ed3c6bb08ff3f85373c673fd92d1429599243584fc46d51a3221782263f26821L130 Signed-off-by: Charlie Le <[email protected]> * Update arguments.md * Remove deprecated flag Signed-off-by: Charlie Le <[email protected]> --------- Signed-off-by: Charlie Le <[email protected]> Signed-off-by: Charlie Le <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This is mostly the rebase of #4679.
The work was done by @aughr . Thanks a lot @aughr !!!!
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]