fix cortex_compactor_remaining_planned_compactions not set after plan generation #4772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roystchiang
force-pushed
the
fix-metrics
branch
3 times, most recently
from
51b7743 to
5c0f7e6
Compare
|
@roystchiang can you please explain why
is an issue? |
|
if users are setting HPA for compactor based on this metric, it will not scale out properly as needed. |
roystchiang
force-pushed
the
fix-metrics
branch
2 times, most recently
from
a088771 to
8f8d2fe
Compare
|
Nice Catch! |
alanprot
approved these changes
Jul 6, 2022
|
@roystchiang can you merge this into release-1.13 branch instead? I will work on merging it back to main branch later - this is part of the release process |
friedrichg
approved these changes
Jul 6, 2022
alvinlin123
reviewed
Jul 6, 2022
CHANGELOG.md
Outdated
| @@ -47,6 +47,7 @@ | |||
| * [BUGFIX] Memberlist: Avoid clock skew by limiting the timestamp accepted on gossip. #4750 | |||
| * [BUGFIX] Compactor: skip compaction if there is only 1 block available for shuffle-sharding compactor. #4756 | |||
| * [BUGFIX] Compactor: Fixes #4770 - an edge case in compactor with shulffle sharding where compaction stops when a tenant stops ingesting samples. #4771 | |||
| * [BUGFIX] Compactor: fix cortex_compactor_remaining_planned_compactions not set after plan generation. #4772 | |||
There was a problem hiding this comment.
Would be nice if we make it clear it's only for shuffle sharding like the above bug fix :-)
… generation Signed-off-by: Roy Chiang <[email protected]>
alvinlin123
added a commit
that referenced
this pull request
Jul 6, 2022
This commit essentially pulls in #4772 from 1.13 release branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
cortex_compactor_remaining_planned_compactionsis not getting set as plans are generated. This PR fixes the issueWhich issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]