Ensure that compaction continues for block with incomplete time-range #4771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
harry671003
force-pushed
the
fix_compactor_group_issue
branch
from
812f708 to
42f0e63
Compare
alanprot
approved these changes
Jul 5, 2022
|
Thanks for looking into this! |
|
LGTM |
alvinlin123
approved these changes
Jul 6, 2022
|
@alanprot @friedrichg what are your opinions about merging this into 1.13 release branch? |
|
I think we can pick... seems a safe change. |
alvinlin123
pushed a commit
that referenced
this pull request
Jul 6, 2022
…#4771) * Ensure that compaction continues for block with incomplete time-range Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]> * Ensure that compaction continues for block with incomplete time-range Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]> * Ensure that compaction continues for block with incomplete time-range Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]> * Ensure that compaction continues for block with incomplete time-range Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
friedrichg
reviewed
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 🌲 Harry 🌊 John 🏔 [email protected]
What this PR does:
This PR tries to address an edge case where compaction stops when a tenant stops ingesting samples. The blocks with incomplete
maxTimewill never be compacted.Which issue(s) this PR fixes:
Fixes #4770
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]