skip compaction if there is only 1 block available for shuffle-sharding compactor #4756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roystchiang
force-pushed
the
skip-compaction-marker
branch
2 times, most recently
from
08d6814 to
c6a2077
Compare
roystchiang
force-pushed
the
skip-compaction-marker
branch
from
c6a2077 to
1c71e88
Compare
alvinlin123
approved these changes
Jun 22, 2022
…ng compactor Signed-off-by: Roy Chiang <[email protected]>
roystchiang
force-pushed
the
skip-compaction-marker
branch
from
1c71e88 to
a6a063e
Compare
alanprot
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the shuffle-sharding compactor will continuously compact a single block into a new block, if there is another compactable block marked for no compaction.
What this PR does:
The compactor will skip compaction groups with only 1 block, after checking for blocks marked for no compact.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]