Reduce the number of series that are kept in memory while streaming from ingesters #4745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harry671003
force-pushed
the
streaming_bug_fix
branch
4 times, most recently
from
7101c6d to
8c81743
Compare
alvinlin123
approved these changes
Jun 3, 2022
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
harry671003
force-pushed
the
streaming_bug_fix
branch
from
8c81743 to
28722db
Compare
harry671003
changed the title
|
That's a nice improvement! LGTM |
alanprot
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 🌲 Harry 🌊 John 🏔 [email protected]
What this PR does:
Addresses an issue where the stream response is left in the memory which increases the overall memory consumption.
Keeping a reference to
respwill also mean that 3x the series (duplicate data fetched from all ingesters) is kept in memory.Before this fix:
After this fix:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]