Enable thanos series limiter in store-gateway #4702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harry671003
force-pushed
the
enable-limits-storegateway
branch
from
211fde4 to
099ce3b
Compare
alvinlin123
approved these changes
Apr 4, 2022
alanprot
reviewed
Apr 5, 2022
| @@ -492,7 +492,7 @@ func (u *BucketStores) getOrCreateStore(userID string) (*store.BucketStore, erro | |||
| fetcher, | |||
| u.syncDirForUser(userID), | |||
| newChunksLimiterFactory(u.limits, userID), | |||
| store.NewSeriesLimiterFactory(0), // No series limiter. | |||
| newSeriesLimiterFactory(u.limits, userID), | |||
There was a problem hiding this comment.
Can we make sure that querier will not retry when this limit is enforced?
There was a problem hiding this comment.
At the moment the querier only retries for missing blocks.
https://github.com/cortexproject/cortex/blob/master/pkg/querier/blocks_store_queryable.go#L515
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
harry671003
force-pushed
the
enable-limits-storegateway
branch
from
099ce3b to
17b2b4d
Compare
alanprot
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 🌲 Harry 🌊 John 🏔 [email protected]
What this PR does:
Currently we're only enforcing the
max_fetched_series_per_querylimit on querier. Not enforcing the series limit on store-gateways could potentially OOM kill them when a large query is executed. This PR enables the Thanos series limiter in store-gateway.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]