update defaultReplicationStrategy to not fail with extend-write when a single instance is unhealthy #4636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roystchiang
force-pushed
the
fix-replication-strategy
branch
2 times, most recently
from
8c1793a to
4832bda
Compare
alvinlin123
approved these changes
Feb 17, 2022
…a single instance is unhealthy Signed-off-by: Roy Chiang <[email protected]>
roystchiang
force-pushed
the
fix-replication-strategy
branch
from
4832bda to
5200af4
Compare
alanprot
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Instead of calculating replication factor in the beginning, calculate it after unhealthy instances have been filtered out. This avoid failure where we have a replication factor of 3, and we have a single unhealthy ingester.
Which issue(s) this PR fixes:
Fixes #4626
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]