Query Frontend: Fix slow query logging if 'LogQueriesLongerThan' is set to < 0 #4633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
bboreham
approved these changes
Jan 25, 2022
pkg/frontend/frontend_test.go
Outdated
Comment on lines
114
to
115
| // Setting to < 0 to ensure all queries are logged. | ||
| config.Handler.LogQueriesLongerThan = -1 * time.Microsecond |
There was a problem hiding this comment.
I was a bit surprised that this is changing what the test does, rather than testing the old and new behaviour.
However I think the test should have had both a slow and a fast query to test the old one properly.
There was a problem hiding this comment.
I thought the reason this was set so low was to in fact log every query for the purpose of this test. But I agree to have both cases tested separately would be nicer, I'll add it.
There was a problem hiding this comment.
I added the test case, let me know what you think!
Signed-off-by: Matej Gera <[email protected]>
alanprot
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matej Gera [email protected]
What this PR does:
Fixes the behavior of Query Frontend when it comes to logging slow queries - if the parameter is set to < 0, all queries should be logged, as is described in the documentation. However, presently, the opposite is true - if set to < 0, logging is disabled altogether.
Leaving the parameter at
0should still retaing the same behavior, i.e. disabling slow query logging.Which issue(s) this PR fixes:
Fixes #4610
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]