Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce ring package #4606

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Jan 7, 2022

What this PR does:
Revert usage of grafana/dskit/ring package. I've copied the current ring code from dskit.

Which issue(s) this PR fixes:

Checklist

  • Tests updated
  • [na] Documentation added
  • [na] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

This reverts commit f2656f8.

Signed-off-by: Arve Knudsen <[email protected]>
@aknuds1 aknuds1 force-pushed the chore/reintroduce-ring branch from 6696713 to c368ada Compare January 12, 2022 14:25
@aknuds1 aknuds1 changed the title WIP: Reintroduce ring package Reintroduce ring package Jan 12, 2022
@aknuds1 aknuds1 marked this pull request as ready for review January 12, 2022 14:42
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No logic changes, LGTM!

@pstibrany pstibrany merged commit 84f240e into cortexproject:master Jan 13, 2022
alvinlin123 pushed a commit to ac1214/cortex that referenced this pull request Jan 14, 2022
This reverts commit f2656f8.

Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Alvin Lin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants