Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Go to 1.17.5 for integration tests + Dockerfiles #4602

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Upgrade Go to 1.17.5 for integration tests + Dockerfiles #4602

merged 2 commits into from
Jan 6, 2022

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Jan 6, 2022 •
edited
Loading

What this PR does:
Upgrade Go to 1.17.5 for integration tests and Dockerfiles.

Which issue(s) this PR fixes:

Checklist

  • [na] Tests updated
  • [na] Documentation added
  • [na] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pstibrany
Copy link
Contributor

Needed for #4601.

@bboreham
Copy link
Contributor

bboreham commented Jan 6, 2022

Why just integration tests? I would think everywhere this repo specifies a Go version should update at the same time.

@aknuds1
Copy link
Contributor Author

aknuds1 commented Jan 6, 2022 •
edited
Loading

Why just integration tests? I would think everywhere this repo specifies a Go version should update at the same time.

@bboreham I've updated in the Dockerfiles, which is where I could find a specific Go version otherwise, except for the build image itself (tagged as 20210713_update-go-1.16.6-178ab0c4f). Is this enough? I figure the minimum Go version (in go.mod) can stay at 1.16.

bboreham
bboreham approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: let's get this merged then update the build image per https://cortexmetrics.io/docs/contributing/how-to-update-the-build-image/

@aknuds1
Copy link
Contributor Author

aknuds1 commented Jan 6, 2022

I think the tests need re-running since ci/test flaked again.

@aknuds1 aknuds1 mentioned this pull request Jan 6, 2022
Closed
@aknuds1 aknuds1 changed the title Upgrade Go to 1.17.5 for integration tests Upgrade Go to 1.17.5 for integration tests + Dockerfiles Jan 6, 2022
@pstibrany pstibrany merged commit f0c5aab into cortexproject:master Jan 6, 2022
@aknuds1 aknuds1 deleted the chore/integration-upgrade-go branch January 6, 2022 15:41
@pstibrany pstibrany mentioned this pull request Jan 6, 2022
Merged
alvinlin123 pushed a commit to ac1214/cortex that referenced this pull request Jan 14, 2022
@aknuds1 @alvinlin123
Upgrade Go to 1.17.5 for integration tests + Dockerfiles (cortexproje…
6653346 
…ct#4602)

* Upgrade Go to 1.17.5 for integration tests

Signed-off-by: Arve Knudsen <[email protected]>

* Upgrade to Go 1.17 in Dockerfiles

Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Alvin Lin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pstibrany pstibrany pstibrany approved these changes

@bboreham bboreham bboreham approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aknuds1 @pstibrany @bboreham