Set appropriate headers in /services endpoint. #4596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
approved these changes
Dec 23, 2021
There was a problem hiding this comment.
Thanks!
Looks like this was an omission from #2673.
Could you reword the CHANGELOG entry so that an administrator can read through the list and get some idea whether they need this fix? It should be understandable without having to refer to the source code.
E.g. "/services html was previously declared to be plain text"
Signed-off-by: Josh Carp <[email protected]>
jmcarp
force-pushed
the
jmcarp/services-content-type
branch
from
ac137a3 to
28b5677
Compare
|
Happy new year @bboreham! I fixed the changelog. Let me know if I missed anything else. |
alvinlin123
approved these changes
Jan 21, 2022
|
@jmcarp thanks for the contribution! Would you be able to fix the conflicts and I'll get this PR merges :-) |
|
Alright, I was afraid that if I make edit through web UI for change log DCO would complain, but looks like it didn't :-) Sorry for the false alarm @jmcarp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Josh Carp [email protected]
What this PR does:
I noticed that the /services endpoint response renders as plain text in some situations. The /services endpoint also sets Content-Type to text/plain when returning json. I see that we always set the Content-type to text/plain in the handler, which I'm proposing we drop unless we need it for some reason.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]