query-frontend: do not log error if context is canceled #4562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My Thanos instance is spamming this whenever the user cancels a query
that is being executed:
```
{"caller":"retry.go:73","err":"context canceled","level":"error","msg":"error processing request","org_id":"anonymous","try":0,"ts":"2021-11-23T13:35:09.275914072Z"}
```
It doesn't mean anything bad so let's stop the spam. Thus, do not perform the
retrying logic if the context has been canceled. Later on this is handled in:
```go
resp, err := f.roundTripper.RoundTrip(r)
queryResponseTime := time.Since(startTime)
if err != nil {
writeError(w, err)
return
}
```
Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
do_not_retry_cancel
branch
from
205ef1d to
a255d5c
Compare
Signed-off-by: Giedrius Statkevičius <[email protected]>
|
Unit tests pass locally just fine, I assume it's the same with integration tests ( |
|
I believe this line means it did not retry: cortex/pkg/querier/queryrange/retry.go Lines 61 to 62 in 4e9fc3a However I agree with you about not logging a cancellation as an error. I might prefer to have the same if-condition in both cases, rather than introducing the new |
pracucci
approved these changes
Dec 2, 2021
bboreham
changed the title
|
Sorry, I was a bit busy. I can change it if you want to 👍 |
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
…#4562) * query-frontend: do not log error if context is canceled Example whenever the user cancels a query that is being executed: ``` {"caller":"retry.go:73","err":"context canceled","level":"error","msg":"error processing request","org_id":"anonymous","try":0,"ts":"2021-11-23T13:35:09.275914072Z"} ``` It doesn't mean anything bad so let's stop the spam. Signed-off-by: Giedrius Statkevičius <[email protected]> Signed-off-by: Alvin Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
My Thanos instance is spamming this whenever the user cancels a query
that is being executed:
It doesn't mean anything bad so let's stop the spam. Thus, do not perform the
retrying logic if the context has been canceled. Later on this is handled in:
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]