Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade thanos version #4394

Merged
merged 4 commits into from
Aug 5, 2021

Conversation

ilangofman
Copy link
Contributor

Signed-off-by: ilangofman [email protected]

What this PR does:

Upgrades the current version of Thanos to the latest main branch. New version: thanos v0.19.1-0.20210729154440-aa148f8fdb28.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: ilangofman <[email protected]>
@ilangofman
Copy link
Contributor Author

In the community call, it was mentioned that the Thanos metrics are mapped in Cortex. I wasn't sure where to look for any changes, can someone please point me to it? I've left it in drafts status until I can verify that if there are any new metrics, then they have been mapped.

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR LGTM. I would add a CHANGELOG entry for the file permissions change, something like this:

* [CHANGE] The directory and file permissions for TSDB blocks stored on disk in ingester, compactor and store-gateway have been restricted to be writeable only by the owner and readable by owner and group. #4394

In the community call, it was mentioned that the Thanos metrics are mapped in Cortex. I wasn't sure where to look for any changes, can someone please point me to it? I've left it in drafts status until I can verify that if there are any new metrics, then they have been mapped.

From a quick look, I think no metrics have been changed, so nothing to do.

Signed-off-by: ilangofman <[email protected]>
@ilangofman ilangofman marked this pull request as ready for review August 4, 2021 13:30
@ilangofman
Copy link
Contributor Author

Thanks for taking a look @pracucci. Really appreciate it. I have added the change log entry.

Signed-off-by: ilangofman <[email protected]>
Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog entry is not quite correct (blocks on ingester are produced by prometheus code, which isn't changed, files generated by thanos code aren't group readable), but otherwise lgtm.

Signed-off-by: Marco Pracucci <[email protected]>
@pracucci pracucci enabled auto-merge (squash) August 5, 2021 11:41
@pracucci pracucci merged commit 7133f01 into cortexproject:master Aug 5, 2021
alvinlin123 pushed a commit to ac1214/cortex that referenced this pull request Jan 14, 2022
* Upgrade thanos version

Signed-off-by: ilangofman <[email protected]>

* Add Changelog

Signed-off-by: ilangofman <[email protected]>

* retrigger tests

Signed-off-by: ilangofman <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Marco Pracucci <[email protected]>

Co-authored-by: Marco Pracucci <[email protected]>
Signed-off-by: Alvin Lin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants