Adding AlertManager SNS Receiver Implementation #4382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanprot
force-pushed
the
alert-manager/sns
branch
from
8ba3b93 to
7d82ad6
Compare
alanprot
force-pushed
the
alert-manager/sns
branch
from
7d82ad6 to
9b3a3a8
Compare
treid314
approved these changes
Aug 5, 2021
alanprot
force-pushed
the
alert-manager/sns
branch
from
9b3a3a8 to
2cdd22a
Compare
|
Done and rebased! :D |
|
Can you please also review this PR @alolita @Aneurysm9? |
bboreham
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
Thanks! Couple of asks before merge:
Please fix the conflict (formatting in CHANGELOG), and also call out the update to Prometheus alertmanager code in the PR description.
Check what else gets picked up by the update - e.g. were there any major bug-fixes or deprecations in alertmanager between the old and new commits.
alanprot
force-pushed
the
alert-manager/sns
branch
2 times, most recently
from
dd96a1e to
fe4e7c0
Compare
Signed-off-by: Alan Protasio <[email protected]>
alanprot
force-pushed
the
alert-manager/sns
branch
from
fe4e7c0 to
852129e
Compare
|
Thanks @bboreham |
treid314
approved these changes
Aug 11, 2021
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
Signed-off-by: Alan Protasio <[email protected]> Signed-off-by: Alvin Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]