-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go version in build image to 1.16.6 #4362
Merged
pracucci
merged 3 commits into
cortexproject:master
from
simonswine:20210713_update-go-1.16.6
Jul 13, 2021
Merged
Update go version in build image to 1.16.6 #4362
pracucci
merged 3 commits into
cortexproject:master
from
simonswine:20210713_update-go-1.16.6
Jul 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4591f03
to
9f23346
Compare
This addresses CVE-2021-34558. golang/go#47143 Signed-off-by: Christian Simon <[email protected]>
9f23346
to
178ab0c
Compare
aknuds1
approved these changes
Jul 13, 2021
gouthamve
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm going to build and publish the updated image. |
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Christian Simon <[email protected]>
pracucci
approved these changes
Jul 13, 2021
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
* Update go version in build image to 1.16.6 This addresses CVE-2021-34558. golang/go#47143 Signed-off-by: Christian Simon <[email protected]> * Update build image and golang version in CI Signed-off-by: Marco Pracucci <[email protected]> * Update LATEST_BUILD_IMAGE_TAG in makefile Signed-off-by: Christian Simon <[email protected]> Co-authored-by: Marco Pracucci <[email protected]> Signed-off-by: Alvin Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Update go version in build image to 1.16.6. This addresses CVE-2021-34558.
golang/go#47143
This now needs a maintainer to push a build image and update references (see https://cortexmetrics.io/docs/contributing/how-to-update-the-build-image/)