Added etcd username and userpassword from config #4205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymhhh
changed the title
|
Thank you for your PR. To make it into mergeable state, please do the following:
Thank you! |
pstibrany
approved these changes
May 20, 2021
CHANGELOG.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| ## master / unreleased | |||
|
|
|||
| * [ENHANCEMENT] Added etcd username and userpassword from config #4205 | |||
There was a problem hiding this comment.
Order of entries in the changelog should be: [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
Suggested change
| * [ENHANCEMENT] Added etcd username and userpassword from config #4205 | |
| * [ENHANCEMENT] Etcd: Added username and password to etcd config. #4205 |
There was a problem hiding this comment.
@ymhhh Could you fix this, please? We would be very happy to merge once done! Thanks!
pracucci
approved these changes
May 24, 2021
CHANGELOG.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| ## master / unreleased | |||
|
|
|||
| * [ENHANCEMENT] Added etcd username and userpassword from config #4205 | |||
There was a problem hiding this comment.
@ymhhh Could you fix this, please? We would be very happy to merge once done! Thanks!
Signed-off-by: Henry Huang <[email protected]>
Signed-off-by: Henry Huang <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use etcd with user & password when it should auth