Validate alertmanager storage configuration when sharding enabled. #4162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storing the "fullstate" objects is not implemented for the "local" and "configdb" storage backend types, or for the legacy storage configuration. Check that these are not given when sharding is enabled. Signed-off-by: Steve Simpson <[email protected]>
pracucci
approved these changes
May 10, 2021
| @@ -250,7 +247,7 @@ func TestAlertmanagerSharding(t *testing.T) { | |||
| require.NoError(t, err) | |||
| defer s.Close() | |||
|
|
|||
| flags := mergeFlags(AlertmanagerFlags(), AlertmanagerS3Flags(testCfg.legacyAlertStore)) | |||
| flags := mergeFlags(AlertmanagerFlags(), AlertmanagerS3Flags(false)) | |||
There was a problem hiding this comment.
Note to other reviewers: this integration test was working anyway for the legacy alertstore because it doesn't test storing/loading state to/from storage.
Signed-off-by: Steve Simpson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Storing the "fullstate" objects is not implemented for the "local" and
"configdb" storage backend types, or for the legacy storage
configuration. Check that these are not given when sharding is enabled.
Checklist
Documentation addedCHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]