Distributors rings status #4151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pracucci Finally I've been able to do it 😄 , hopefully, I haven't done something totally weird that is not what we want |
pracucci
approved these changes
May 4, 2021
pstibrany
approved these changes
May 5, 2021
pkg/distributor/distributor.go
Outdated
Comment on lines
1056
to
1057
| w.WriteHeader(http.StatusOK) | ||
| _, err := w.Write([]byte(unshardedPage)) | ||
| if err != nil { | ||
| level.Error(d.log).Log("msg", "unable to serve status page", "err", err) | ||
| } | ||
| } |
There was a problem hiding this comment.
Is this worth moving to WriteHTMLResponse in pkg/util/http.go?
Also there is no need to log the error while writing response. It's likely that client has disconnected, at that point, we cannot do anything about it.
There was a problem hiding this comment.
Yeah it makes sense so I've created that method and now we're using it in rules and distributor :)
Now we're able to see the ring status for the distributor when the ingestion-rate-limit-strategy setting is set to global Signed-off-by: Mario de Frutos <[email protected]>
Signed-off-by: Mario de Frutos <[email protected]>
Signed-off-by: Mario de Frutos <[email protected]>
Signed-off-by: Mario de Frutos <[email protected]>
Signed-off-by: Mario de Frutos <[email protected]>
ethervoid
force-pushed
the
3656_ring_status_distributors
branch
from
10f894a to
90fd9b3
Compare
|
All changes tackled :) |
|
Thanks for addressing our feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Now we're able to see the ring status for the distributor when the ingestion-rate-limit-strategy
the setting is set to global
Which issue(s) this PR fixes:
Fixes #3656
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]