Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot fix to avoid process to block indefinitely on shutdown #4134

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Hot fix to avoid process to block indefinitely on shutdown #4134

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
079daff
Hot fix to avoid process to block indefinitely on shutdown
pracucci Apr 28, 2021
1352a30
Added CHANGELOG entry
pracucci Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmd/cortex/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,10 @@ func main() {
}

// Setting the environment variable JAEGER_AGENT_HOST enables tracing.
if trace, err := tracing.NewFromEnv(name); err != nil {
// Do NOT call trace.Close() because of an known issue which could cause the process to block indefinitely
// on shutdown. See: https://github.com/jaegertracing/jaeger-client-go/issues/577
if _, err := tracing.NewFromEnv(name); err != nil {
level.Error(util_log.Logger).Log("msg", "Failed to setup tracing", "err", err.Error())
} else {
defer trace.Close()
}
}

Expand Down