Remove config options deprecated in Cortex 1.6 #4101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
remove-deprecated-features
branch
from
0e44264 to
84c48b5
Compare
|
I'm going to merge it to move forward. I will address any post-merge comment in case there will be any. |
ts-mini
added a commit
to ts-mini/cortex-helm-chart
that referenced
this pull request
May 27, 2021
Signed-off-by: Tyler Horvath <[email protected]>
ts-mini
added a commit
to ts-mini/cortex-helm-chart
that referenced
this pull request
May 27, 2021
ts-mini
added a commit
to ts-mini/cortex-helm-chart
that referenced
this pull request
May 27, 2021
Signed-off-by: Tyler Horvath <[email protected]>
ts-mini
added a commit
to ts-mini/cortex-helm-chart
that referenced
this pull request
May 27, 2021
Signed-off-by: Tyler Horvath <[email protected]>
ts-mini
added a commit
to ts-mini/cortex-helm-chart
that referenced
this pull request
May 27, 2021
Signed-off-by: Tyler Horvath <[email protected]>
ts-mini
added a commit
to ts-mini/cortex-helm-chart
that referenced
this pull request
Jun 4, 2021
Signed-off-by: Tyler Horvath <[email protected]>
ts-mini
added a commit
to ts-mini/cortex-helm-chart
that referenced
this pull request
Jun 4, 2021
Signed-off-by: Tyler Horvath <[email protected]>
nschad
added a commit
to cortexproject/cortex-helm-chart
that referenced
this pull request
Jun 4, 2021
* Adjusting values for cortexproject/cortex#4101 Signed-off-by: Tyler Horvath <[email protected]> * fixing per: cortexproject/cortex#4101 Signed-off-by: Tyler Horvath <[email protected]> * this goes in limits Signed-off-by: Tyler Horvath <[email protected]> * Adjusting alert manager statefulset config for 1.9 Signed-off-by: Tyler Horvath <[email protected]> * Adding changelog Signed-off-by: Tyler Horvath <[email protected]> * I passed an english class once upon a time Signed-off-by: Tyler Horvath <[email protected]> Co-authored-by: Niclas Schad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
We're about to cut Cortex 1.9.0, so it's time to remove config options which were deprecated in Cortex 1.6. I've also took the opportunity to mark some features we're using in prod since a long time (and that we don't expect their config to change) as stable.
I've spoken to Josh and he mentioned Alertmanager and Ruler API may still be subject to change so I haven't marked them as stable even if we're running them in prod since months.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]