Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest github.com/weaveworks/common #4099

Merged
merged 2 commits into from
Apr 22, 2021

Conversation

stevesg
Copy link
Contributor

@stevesg stevesg commented Apr 22, 2021

What this PR does:
Update to latest github.com/weaveworks/common in order to inherit tcp_connections metric.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Steve Simpson <[email protected]>
Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@stevesg stevesg marked this pull request as ready for review April 22, 2021 07:50
@pracucci pracucci merged commit 4e2373b into cortexproject:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants