Increment cortex_compactor_runs_failed_total if compactor fails to compact a single tenant #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roystchiang
force-pushed
the
fix-compactor-metric
branch
2 times, most recently
from
fe80343 to
b112ede
Compare
…mpact a single tenant Signed-off-by: Roy Chiang <[email protected]>
roystchiang
force-pushed
the
fix-compactor-metric
branch
from
b112ede to
d62d8c7
Compare
pracucci
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roy Chiang [email protected]
What this PR does:
In a previous change, the behavior of cortex_compactor_runs_failed_total was updated. Originally this metric is incremented when it a single tenant is failed to be compacted. The new behavior will only increment this metric if the compactor failed to discover users.
This change updates the behavior back to how it was originally.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]