Ruler ignore users #4074
Merged
Ruler ignore users #4074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
gotjosh
reviewed
Apr 13, 2021
Signed-off-by: Peter Štibraný <[email protected]>
|
Thanks for your reviews! I've now addressed all your feedback. |
gotjosh
approved these changes
Apr 14, 2021
| @@ -277,6 +277,8 @@ func TestSharding(t *testing.T) { | |||
| shardingStrategy string | |||
| shuffleShardSize int | |||
| setupRing func(*ring.Desc) | |||
| enabledUsers []string | |||
There was a problem hiding this comment.
nit: not sure if intended given I see other occurrences of the word but we're still using the Users suffix throughout this test.
There was a problem hiding this comment.
I would need to change entire test to replace that. Doesn't seem to be worth the effort. I've changed ruler.go and compactor.go though.
Signed-off-by: Peter Štibraný <[email protected]>
gotjosh
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR adds
-ruler.enabled-tenantsand-ruler.disabled-tenantsoptions to explicitly enable or disable rules processing for specific tenants. Code is extracted from Compactor, where this support already exists.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]