Convert all validation.Limits durations to model.Duration #4044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Pillitteri <[email protected]>
Use the prometheus/common model.Duration for all duration related limits instead of the standard library time.Duration type. This works around an issue with the JSON representation of the standard library type. For example: * The YAML representation of time.Duration(1 * time.Second) is the string `1s` * The JSON representation of time.Duration(1 * time.Second) is the integer `1000000000` By contrast: * The YAML representation of model.Duration(1 * time.Second) is the string `1s` * The JSON representation of model.Duration(1 * time.Second) is the string `1s` Signed-off-by: Nick Pillitteri <[email protected]>
Signed-off-by: Nick Pillitteri <[email protected]>
jtlisi
approved these changes
Apr 2, 2021
Co-authored-by: Jacob Lisi <[email protected]> Signed-off-by: Nick Pillitteri <[email protected]>
pracucci
approved these changes
Apr 2, 2021
Signed-off-by: Nick Pillitteri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Use the prometheus/common model.Duration for all duration related
limits instead of the standard library time.Duration type. This works
around an issue with the JSON representation of the standard library
type.
For example:
time.Duration(1 * time.Second)is the string1stime.Duration(1 * time.Second)is the integer1000000000By contrast:
model.Duration(1 * time.Second)is the string1smodel.Duration(1 * time.Second)is the string1sThe first commit in this PR demonstrates this issue with a unit test.
Note that the
Overridesstruct still convertsmodel.Durationtotime.Durationfor each respective limit method (the same way
MaxQueryLookbackalreadywas).
Signed-off-by: Nick Pillitteri [email protected]
Checklist
- [ ] Documentation addedCHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]