Use non APIPA when assigning IP Address #4032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtlisi
reviewed
Apr 15, 2021
There was a problem hiding this comment.
Thank you for the contribution, if you get a chance can you look into adding a DCO signature to your commits. Also I'd like to make a suggestion.
suggestion: Instead of using two label breaking loops, consider pushing logic in the filterIPs for loop into a separate function. This will allow for two things:
- The code can be rewritten to not use label breaks
- It will be easy to add unit tests to the new function that replaces the
filterIPsloop.
@jbvmio WDYT?
|
Sounds good to me @jtlisi, appreciate the feedback. |
Signed-off-by: Jimmy Bonds <[email protected]>
Signed-off-by: Jimmy Bonds <[email protected]>
|
@jtlisi Change log entry added, thanks! |
Signed-off-by: Jimmy Bonds <[email protected]>
Signed-off-by: Jimmy Bonds <[email protected]>
pstibrany
reviewed
May 10, 2021
Signed-off-by: Jimmy Bonds <[email protected]>
Signed-off-by: Jimmy Bonds <[email protected]>
Signed-off-by: Jimmy Bonds <[email protected]>
pstibrany
approved these changes
May 21, 2021
Signed-off-by: Jimmy Bonds <[email protected]>
Signed-off-by: Jimmy Bonds <[email protected]>
|
Thank you for addressing my feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Returns the first non Automatic Private IP if possible. Will return APIP as last resort.
Which issue(s) this PR fixes:
Fixes or addresses #4014