Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure ruler returns 404 when getting missing rule group #4013

Merged
merged 3 commits into from
Mar 26, 2021
Merged

fix: ensure ruler returns 404 when getting missing rule group #4013

merged 3 commits into from
Mar 26, 2021

Conversation

jtlisi
Copy link
Contributor

@jtlisi jtlisi commented Mar 25, 2021 •
edited
Loading

What this PR does:

TODO

  • Add regression test
  • Update CHANGELOG.md

@jtlisi
chore: update changelog
5c1e3c1 
Signed-off-by: Jacob Lisi <[email protected]>
@jtlisi jtlisi requested a review from pstibrany March 25, 2021 20:54
pstibrany
pstibrany approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find.

@jtlisi jtlisi merged commit 422af37 into master Mar 26, 2021
@jtlisi jtlisi deleted the 20210325_ruler_api_fix branch March 26, 2021 02:12
pracucci
pracucci reviewed Mar 29, 2021
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pracucci pracucci pracucci left review comments

@pstibrany pstibrany pstibrany approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruler is not correctly returning 404 for missing rule groups
3 participants
@jtlisi @pstibrany @pracucci