Deprecated old alertmanager storage config #4002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
commented
Mar 24, 2021
| @@ -4,7 +4,8 @@ | |||
|
|
|||
| * [CHANGE] Alertmanager now removes local files after Alertmanager is no longer running for removed or resharded user. #3910 | |||
| * [CHANGE] Alertmanager now stores local files in per-tenant folders. Files stored by Alertmanager previously are migrated to new hierarchy. Support for this migration will be removed in Cortex 1.11. #3910 | |||
| * [CHANGE] Ruler: deprecated `-ruler.storage.*` CLI flags (and their respective YAML config options) in favour of `-ruler-storage.*`. The deprecated config will be removed in Cortex 1.11. #3944 | |||
| * [CHANGE] Ruler: deprecated `-ruler.storage.*` CLI flags (and their respective YAML config options) in favour of `-ruler-storage.*`. The deprecated config will be removed in Cortex 1.11. #3945 | |||
There was a problem hiding this comment.
I fixed the PR number here. It was wrong.
pstibrany
approved these changes
Mar 24, 2021
gotjosh
approved these changes
Mar 24, 2021
|
I'm confused: is this about storage or about config? The former is for things like silences and the latter is for things like routing rules. For example |
bboreham
reviewed
May 10, 2021
| @@ -4,7 +4,8 @@ | |||
|
|
|||
| * [CHANGE] Alertmanager now removes local files after Alertmanager is no longer running for removed or resharded user. #3910 | |||
| * [CHANGE] Alertmanager now stores local files in per-tenant folders. Files stored by Alertmanager previously are migrated to new hierarchy. Support for this migration will be removed in Cortex 1.11. #3910 | |||
| * [CHANGE] Ruler: deprecated `-ruler.storage.*` CLI flags (and their respective YAML config options) in favour of `-ruler-storage.*`. The deprecated config will be removed in Cortex 1.11. #3944 | |||
| * [CHANGE] Ruler: deprecated `-ruler.storage.*` CLI flags (and their respective YAML config options) in favour of `-ruler-storage.*`. The deprecated config will be removed in Cortex 1.11. #3945 | |||
| * [CHANGE] Alertmanager: deprecated `-alertmanager.storage.*` CLI flags (and their respective YAML config options) in favour of `-alertmanager-storage.*`. The deprecated config will be removed in Cortex 1.11. #4002 | |||
There was a problem hiding this comment.
As far as I can see this is not true for these two fields:
cortex/pkg/alertmanager/multitenant.go
Lines 146 to 147 in 851b164
This is about deprecating the object storage backend for storing each tenants alertmanager config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In #3888 we introduced the new alertmanager storage config. In this PR I'm proposing to deprecate the old storage config, so that it will be officially marked as deprecated in Cortex 1.9 and then removed in 1.11.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]