Revert "Prevent failed ingestion from affecting rate limiting in distributor. (#3825)" #3948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ributor. (cortexproject#3825)" This reverts commit 9ba848b. Signed-off-by: Marco Pracucci <[email protected]>
bboreham
approved these changes
Mar 12, 2021
pstibrany
pushed a commit
to pstibrany/cortex
that referenced
this pull request
Mar 15, 2021
…ributor. (cortexproject#3825)" (cortexproject#3948) This reverts commit 9ba848b. Signed-off-by: Marco Pracucci <[email protected]> (cherry picked from commit 6aa2a69)
pstibrany
added a commit
that referenced
this pull request
Mar 15, 2021
* Revert "Prevent failed ingestion from affecting rate limiting in distributor. (#3825)" (#3948) This reverts commit 9ba848b. Signed-off-by: Marco Pracucci <[email protected]> (cherry picked from commit 6aa2a69) * Update VERSION Signed-off-by: Peter Štibraný <[email protected]> Co-authored-by: Marco Pracucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
We had an incident with a customer remote writing an high volume of out of order samples, which basically bypassed the rate limit because of the changes done in #3825 and the issue described in #3890.
Given we want to improve the rate limit, I would suggest to quickly rollback #3825 and take more time to properly address the ingestion rate limit. I think we should backport this rollback to 1.8 too. /cc @pstibrany
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]