Deprecate old ruler storage config #3945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
commented
Mar 12, 2021
| @@ -3,8 +3,9 @@ | |||
| ## master / unreleased | |||
|
|
|||
| * [CHANGE] Alertmanager now removes local files after Alertmanager is no longer running for removed or resharded user. #3910 | |||
| * [CHANGE] Alertmanager now stores local files in per-tenant folders. Files stored by Alertmanager previously are migrated to new hierarchy. Support for this migration will be removed in Cortex 1.10. #3910 | |||
There was a problem hiding this comment.
I've changed this from 1.10 to 1.11 because we have to keep deprecated features for 2 releases so since this will end up in 1.9 we can remove it in 1.11. Am I missing anything?
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
commented
Mar 12, 2021
| @@ -153,213 +153,8 @@ tenant_federation: | |||
| # The ruler_config configures the Cortex ruler. | |||
| [ruler: <ruler_config>] | |||
|
|
|||
| ruler_storage: | |||
There was a problem hiding this comment.
Moved below to its dedication section to keep this huge reference file cleaner.
jtlisi
approved these changes
Mar 12, 2021
| @@ -3,8 +3,9 @@ | |||
| ## master / unreleased | |||
|
|
|||
| * [CHANGE] Alertmanager now removes local files after Alertmanager is no longer running for removed or resharded user. #3910 | |||
| * [CHANGE] Alertmanager now stores local files in per-tenant folders. Files stored by Alertmanager previously are migrated to new hierarchy. Support for this migration will be removed in Cortex 1.10. #3910 | |||
| @@ -153,213 +153,8 @@ tenant_federation: | |||
| # The ruler_config configures the Cortex ruler. | |||
| [ruler: <ruler_config>] | |||
|
|
|||
| ruler_storage: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
We've rolled out the new ruler storage config in our cluster and so far looks good. I would like to do the next step which is marking the old config as deprecated and the new one as stable (will be effective only once 1.9 will be released so about 5 weeks from now).
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]