Added local backend support to new ruler storage config #3932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In the PR #3805 Jacob has introduced the new ruler storage config using the Thanos objstore clients. As discussed several Cortex community meetings ago, we would like to deprecate the old objstore clients/config and to do that we need to add
local
backend support to the new config, which is what I'm proposing in this PR.To avoid cyclic dependencies I had to do a bit of refactoring:
RuleGroupList
topkg/ruler/rulespb
(this is something we've done in other packages too and I think it's fine)Move errors to/pkg/ruler/rulestore/errors
(not a big fan of this, suggestions are welcome)Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]