Update alertmanager #3903
Merged
Update alertmanager #3903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The biggest changes are time-based muting and the inclusion of interfaces for the clustering logic. The latter supports the Alertmanager replication via the ring. Signed-off-by: gotjosh <[email protected]>
We don't want to expose information about the cluster back to tenants. Signed-off-by: gotjosh <[email protected]>
3 tasks
Signed-off-by: gotjosh <[email protected]>
pstibrany
approved these changes
Mar 3, 2021
There was a problem hiding this comment.
LGTM.
There's one more important change from upstream: Time-based muting, which is a new section in the config. Do we typically include those in the changelog?
If it is relevant for Cortex operators (change, new available feature) then it is worth mentioning.
|
I guess it's not getting listed then - this only affects tenants as opposed to operators. |
roystchiang
pushed a commit
to roystchiang/cortex
that referenced
this pull request
Apr 6, 2022
* Update Alertmanager dependency to master The biggest changes are time-based muting and the inclusion of interfaces for the clustering logic. The latter supports the Alertmanager replication via the ring. Signed-off-by: gotjosh <[email protected]> * Use NilPeer for the API clustering interface. We don't want to expose information about the cluster back to tenants. Signed-off-by: gotjosh <[email protected]> * gofmt fails me Signed-off-by: gotjosh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Updates the upstream Alertmanager dependency to align with the main branch.
There's one more important change from upstream: Time-based muting, which is a new section in the config. Do we typically include those in the changelog?
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]