Returning 422 (instead 500) when query hit max_chunks_per_query limit with block storage #3895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanprot
changed the title
alanprot
changed the title
alanprot
force-pushed
the
enhancement/422-on-query-max-chunks
branch
from
916cbc9 to
196acfd
Compare
alanprot
changed the title
alanprot
force-pushed
the
enhancement/422-on-query-max-chunks
branch
from
196acfd to
19d0f54
Compare
alanprot
changed the title
alanprot
changed the title
Signed-off-by: Alan Protasio <[email protected]>
alanprot
force-pushed
the
enhancement/422-on-query-max-chunks
branch
from
19d0f54 to
bb1d2b0
Compare
nicolai86
approved these changes
Mar 2, 2021
alanprot
force-pushed
the
enhancement/422-on-query-max-chunks
branch
from
a0efef3 to
bb1d2b0
Compare
Co-authored-by: Peter Štibraný <[email protected]> Signed-off-by: Alan Protasio <[email protected]>
alanprot
force-pushed
the
enhancement/422-on-query-max-chunks
branch
from
3d28c60 to
58e6c8a
Compare
|
Thanks @pstibrany |
pracucci
reviewed
Mar 2, 2021
Signed-off-by: Marco Pracucci <[email protected]>
2 tasks
pracucci
pushed a commit
that referenced
this pull request
Apr 8, 2021
…`max_chunks_per_query` limit with block storage (#3937) * Updating thanos Signed-off-by: Alan Protasio <[email protected]> * Returning 422 when chunk limits are reached Signed-off-by: Alan Protasio <[email protected]> * Addresing PR comments Signed-off-by: Alan Protasio <[email protected]> * Updating Changelog Signed-off-by: Alan Protasio <[email protected]>
roystchiang
pushed a commit
to roystchiang/cortex
that referenced
this pull request
Apr 6, 2022
… with block storage (cortexproject#3895) * Returning 422 (instead 500) when query hit max_chunks_per_query limit Signed-off-by: Alan Protasio <[email protected]> * Update CHANGELOG.md Co-authored-by: Peter Štibraný <[email protected]> Signed-off-by: Alan Protasio <[email protected]> * Update CHANGELOG.md Signed-off-by: Marco Pracucci <[email protected]> Co-authored-by: Peter Štibraný <[email protected]> Co-authored-by: Marco Pracucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, i think we should return 422 instead of 500 when a query hits the max_chunks_per_query limits
What this PR does:
Return 422 instead of 500 when a query hits the max_chunks_per_query limits
Same type of error is used here with
max_query_lengthlimit and this error is translated to 422 as explained hereWhich issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]